Post by stevan on Jun 19, 2023 14:55:12 GMT
all tests up through the end of chapter 11 pass, but running the code for the image on page 159 which jamis gives in an earlier thread here:
forum.raytracerchallenge.com/thread/91/ch-11-reflection-refraction-problem
produces the following image:
this may be related to another problem.
shade_hit calls reflected_color and refracted_color with remaining. in the book, reflected_color returns 0 0 0 if remaining<1, but refracted_color does not. this produces a stack error when running the code to produce the image above, even though all tests pass. to avoid the stack error, i've added the remaining<1 test to refracted_color and return 0 0 0 in that case. (i think i noticed that at least one other person did the same thing.)
the call-hierarchy in my code is:
shade_hit remaining
-> reflected_color remaining, return 0 0 0 if remaining<1
-> color_at remaining-1
-> shade_hit remaining
-> refracted_color remaining, return 0 0 0 if remaining<1
-> color_at remaining-1
-> shade_hut remaining
suggestions welcome - thanks!
forum.raytracerchallenge.com/thread/91/ch-11-reflection-refraction-problem
produces the following image:
this may be related to another problem.
shade_hit calls reflected_color and refracted_color with remaining. in the book, reflected_color returns 0 0 0 if remaining<1, but refracted_color does not. this produces a stack error when running the code to produce the image above, even though all tests pass. to avoid the stack error, i've added the remaining<1 test to refracted_color and return 0 0 0 in that case. (i think i noticed that at least one other person did the same thing.)
the call-hierarchy in my code is:
shade_hit remaining
-> reflected_color remaining, return 0 0 0 if remaining<1
-> color_at remaining-1
-> shade_hit remaining
-> refracted_color remaining, return 0 0 0 if remaining<1
-> color_at remaining-1
-> shade_hut remaining
suggestions welcome - thanks!
